rusty-donkey/heave
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

review: rewrite sqlite_build_params and remove useless tests

Browse Source
This commit is contained in:
davidemazzocchi
2025-10-19 07:50:13 +02:00
parent 489492ab15
commit c385dbf85f
1 changed files with 3 additions and 89 deletions
Download Patch File Download Diff File Expand all files Collapse all files

92
01.workspace/heave/src/fun/sqlite_build_params.rs
View File

@@ -1,100 +1,14 @@
use crate::*; use crate::*;
use rusqlite::*; use rusqlite::*;
pub fn run(filter: &Filter) -> Result<Vec<Box<dyn ToSql>>, FailedTo> { pub fn run<'a>(filter: &'a Filter) -> Result<Vec<Box<dyn ToSql + 'a>>, FailedTo> {
let mut params: Vec<Box<dyn ToSql>> = Vec::new(); let mut params: Vec<Box<dyn ToSql>> = Vec::new();
for condition in filter.conditions() { for condition in filter.conditions() {
match condition.2 { let (_, _, condition) = condition;
match condition {
Condition::Bool(value) => params.push(Box::new(value)), Condition::Bool(value) => params.push(Box::new(value)),
Condition::SignedInt(value) => params.push(Box::new(value)), Condition::SignedInt(value) => params.push(Box::new(value)),
} }
} }
Ok(params) Ok(params)
} }
#[cfg(test)]
mod tests {
use super::*;
// Ensures that an empty vector is returned when the filter has no conditions.
#[test]
fn returns_empty_vec_for_empty_filter() {
let filter = Filter::new();
let params = run(&filter).unwrap();
assert!(params.is_empty());
}
// Verifies that a single boolean condition is correctly converted to a ToSql parameter.
#[test]
fn returns_params_for_one_bool_condition() {
let filter = Filter::new().with_bool("is_active", true);
let params = run(&filter).unwrap();
assert_eq!(params.len(), 1);
assert_eq!(
params[0].to_sql().unwrap(),
rusqlite::types::ToSqlOutput::Owned(rusqlite::types::Value::Integer(1))
);
}
// Checks that multiple boolean conditions are correctly converted and ordered.
#[test]
fn returns_params_for_multiple_bool_conditions() {
let filter = Filter::new()
.with_bool("is_active", true)
.with_bool("is_deleted", false);
let params = run(&filter).unwrap();
assert_eq!(params.len(), 2);
assert_eq!(
params[0].to_sql().unwrap(),
rusqlite::types::ToSqlOutput::Owned(rusqlite::types::Value::Integer(1))
);
assert_eq!(
params[1].to_sql().unwrap(),
rusqlite::types::ToSqlOutput::Owned(rusqlite::types::Value::Integer(0))
);
}
// Verifies that a single signed integer condition is correctly converted to a ToSql parameter.
#[test]
fn returns_params_for_one_signed_int_condition() {
let filter = Filter::new().with_signed_int("level", Comparison::Equal, -5);
let params = run(&filter).unwrap();
assert_eq!(params.len(), 1);
assert_eq!(
params[0].to_sql().unwrap(),
rusqlite::types::ToSqlOutput::Owned(rusqlite::types::Value::Integer(-5))
);
}
// Checks that multiple signed integer conditions are correctly converted and ordered.
#[test]
fn returns_params_for_multiple_signed_int_conditions() {
let filter = Filter::new()
.with_signed_int("level", Comparison::Equal, -5)
.with_signed_int("score", Comparison::Equal, 100);
let params = run(&filter).unwrap();
assert_eq!(params.len(), 2);
assert_eq!(
params[0].to_sql().unwrap(),
rusqlite::types::ToSqlOutput::Owned(rusqlite::types::Value::Integer(-5))
);
assert_eq!(
params[1].to_sql().unwrap(),
rusqlite::types::ToSqlOutput::Owned(rusqlite::types::Value::Integer(100))
);
}
// Tests conversion for a mix of boolean and signed integer conditions.
#[test]
fn returns_params_for_mixed_conditions() {
let filter = Filter::new().with_bool("is_active", true).with_signed_int(
"level",
Comparison::Equal,
-10,
);
let params = run(&filter).unwrap();
assert_eq!(params.len(), 2);
assert_eq!(
params[0].to_sql().unwrap(),
rusqlite::types::ToSqlOutput::Owned(rusqlite::types::Value::Integer(1))
);
assert_eq!(
params[1].to_sql().unwrap(),
rusqlite::types::ToSqlOutput::Owned(rusqlite::types::Value::Integer(-10))
);
}
}