feat: handle comparison "greater" for signed int condition

This commit is contained in:
2025-10-19 09:44:48 +02:00
parent 377b232128
commit 8e8e964e3f
2 changed files with 103 additions and 10 deletions

View File

@@ -26,6 +26,9 @@ pub fn run(filter: &Filter) -> Result<String, FailedTo> {
(Comparison::Equal, Condition::SignedInt(_)) => { (Comparison::Equal, Condition::SignedInt(_)) => {
compose_fragment(name, "value_int", "=", i + 1) compose_fragment(name, "value_int", "=", i + 1)
} }
(Comparison::Greater, Condition::SignedInt(_)) => {
compose_fragment(name, "value_int", ">", i + 1)
}
_ => todo!(), _ => todo!(),
}; };
statement.push_str(&fragment); statement.push_str(&fragment);

View File

@@ -1474,7 +1474,6 @@ mod tests {
assert_eq!(result.unwrap_err(), FailedTo::LoadFromDB); assert_eq!(result.unwrap_err(), FailedTo::LoadFromDB);
std::fs::remove_dir_all(invalid_path).unwrap(); std::fs::remove_dir_all(invalid_path).unwrap();
} }
#[test] #[test]
fn load_by_filter_should_load_matching_sell_trend() { fn load_by_filter_should_load_matching_sell_trend() {
let db_path = "target/test_dbs/lbf_matching_sell_trend.db"; let db_path = "target/test_dbs/lbf_matching_sell_trend.db";
@@ -1483,7 +1482,6 @@ mod tests {
if path.exists() { if path.exists() {
std::fs::remove_file(path).unwrap(); std::fs::remove_file(path).unwrap();
} }
let mut catalog_setup = Catalog::new(db_path); let mut catalog_setup = Catalog::new(db_path);
catalog_setup.init().unwrap(); catalog_setup.init().unwrap();
let items = vec![ let items = vec![
@@ -1511,19 +1509,15 @@ mod tests {
]; ];
catalog_setup.insert_many(items).unwrap(); catalog_setup.insert_many(items).unwrap();
catalog_setup.persist().unwrap(); catalog_setup.persist().unwrap();
let mut catalog = Catalog::new(db_path); let mut catalog = Catalog::new(db_path);
let filter = Filter::new().with_signed_int("sell_trend", Comparison::Equal, 10); let filter = Filter::new().with_signed_int("sell_trend", Comparison::Equal, 10);
assert!(catalog.load_by_filter(&filter).is_ok()); assert!(catalog.load_by_filter(&filter).is_ok());
assert_eq!(catalog.items.len(), 2); assert_eq!(catalog.items.len(), 2);
assert!(catalog.items.contains_key("item-1")); assert!(catalog.items.contains_key("item-1"));
assert!(catalog.items.contains_key("item-3")); assert!(catalog.items.contains_key("item-3"));
assert!(!catalog.items.contains_key("item-2")); assert!(!catalog.items.contains_key("item-2"));
std::fs::remove_file(path).unwrap(); std::fs::remove_file(path).unwrap();
} }
#[test] #[test]
fn load_by_filter_should_load_matching_negative_sell_trend() { fn load_by_filter_should_load_matching_negative_sell_trend() {
let db_path = "target/test_dbs/lbf_matching_negative_sell_trend.db"; let db_path = "target/test_dbs/lbf_matching_negative_sell_trend.db";
@@ -1532,7 +1526,6 @@ mod tests {
if path.exists() { if path.exists() {
std::fs::remove_file(path).unwrap(); std::fs::remove_file(path).unwrap();
} }
let mut catalog_setup = Catalog::new(db_path); let mut catalog_setup = Catalog::new(db_path);
catalog_setup.init().unwrap(); catalog_setup.init().unwrap();
let items = vec![ let items = vec![
@@ -1560,16 +1553,113 @@ mod tests {
]; ];
catalog_setup.insert_many(items).unwrap(); catalog_setup.insert_many(items).unwrap();
catalog_setup.persist().unwrap(); catalog_setup.persist().unwrap();
let mut catalog = Catalog::new(db_path); let mut catalog = Catalog::new(db_path);
let filter = Filter::new().with_signed_int("sell_trend", Comparison::Equal, -5); let filter = Filter::new().with_signed_int("sell_trend", Comparison::Equal, -5);
assert!(catalog.load_by_filter(&filter).is_ok()); assert!(catalog.load_by_filter(&filter).is_ok());
assert_eq!(catalog.items.len(), 1); assert_eq!(catalog.items.len(), 1);
assert!(catalog.items.contains_key("item-2")); assert!(catalog.items.contains_key("item-2"));
assert!(!catalog.items.contains_key("item-1")); assert!(!catalog.items.contains_key("item-1"));
assert!(!catalog.items.contains_key("item-3")); assert!(!catalog.items.contains_key("item-3"));
std::fs::remove_file(path).unwrap();
}
#[test]
fn load_by_filter_should_load_matching_greater_sell_trend() {
let db_path = "target/test_dbs/lbf_matching_greater_sell_trend.db";
let path = std::path::Path::new(db_path);
std::fs::create_dir_all(path.parent().unwrap()).unwrap();
if path.exists() {
std::fs::remove_file(path).unwrap();
}
let mut catalog_setup = Catalog::new(db_path);
catalog_setup.init().unwrap();
let items = vec![
Item {
id: "item-1".to_string(),
name: "Item One".to_string(),
price: 100,
sell_trend: 10,
in_stock: true,
},
Item {
id: "item-2".to_string(),
name: "Item Two".to_string(),
price: 200,
sell_trend: -5,
in_stock: false,
},
Item {
id: "item-3".to_string(),
name: "Item Three".to_string(),
price: 300,
sell_trend: 20,
in_stock: true,
},
];
catalog_setup.insert_many(items).unwrap();
catalog_setup.persist().unwrap();
let mut catalog = Catalog::new(db_path);
let filter = Filter::new().with_signed_int("sell_trend", Comparison::Greater, 5);
assert!(catalog.load_by_filter(&filter).is_ok());
assert_eq!(catalog.items.len(), 2);
assert!(catalog.items.contains_key("item-1"));
assert!(!catalog.items.contains_key("item-2"));
assert!(catalog.items.contains_key("item-3"));
std::fs::remove_file(path).unwrap();
}
#[test]
fn load_by_filter_should_load_matching_greater_sell_trend_edge_cases() {
let db_path = "target/test_dbs/lbf_greater_sell_trend_edge_cases.db";
let path = std::path::Path::new(db_path);
std::fs::create_dir_all(path.parent().unwrap()).unwrap();
if path.exists() {
std::fs::remove_file(path).unwrap();
}
let mut catalog_setup = Catalog::new(db_path);
catalog_setup.init().unwrap();
let items = vec![
Item {
id: "item-1".to_string(),
name: "Item One".to_string(),
price: 100,
sell_trend: 10,
in_stock: true,
},
Item {
id: "item-2".to_string(),
name: "Item Two".to_string(),
price: 200,
sell_trend: -5,
in_stock: false,
},
Item {
id: "item-3".to_string(),
name: "Item Three".to_string(),
price: 300,
sell_trend: 20,
in_stock: true,
},
];
catalog_setup.insert_many(items).unwrap();
catalog_setup.persist().unwrap();
// Edge Case 1: Value equal to filter value should not be included.
let mut catalog1 = Catalog::new(db_path);
let filter1 = Filter::new().with_signed_int("sell_trend", Comparison::Greater, 10);
assert!(catalog1.load_by_filter(&filter1).is_ok());
assert_eq!(catalog1.items.len(), 1);
assert!(catalog1.items.contains_key("item-3"));
// Edge Case 2: No values greater than filter value.
let mut catalog2 = Catalog::new(db_path);
let filter2 = Filter::new().with_signed_int("sell_trend", Comparison::Greater, 20);
assert!(catalog2.load_by_filter(&filter2).is_ok());
assert!(catalog2.items.is_empty());
// Edge Case 3: All values greater than filter value.
let mut catalog3 = Catalog::new(db_path);
let filter3 = Filter::new().with_signed_int("sell_trend", Comparison::Greater, -10);
assert!(catalog3.load_by_filter(&filter3).is_ok());
assert_eq!(catalog3.items.len(), 3);
assert!(catalog3.items.contains_key("item-1"));
assert!(catalog3.items.contains_key("item-2"));
assert!(catalog3.items.contains_key("item-3"));
std::fs::remove_file(path).unwrap(); std::fs::remove_file(path).unwrap();
} }
// ## Integration Tests // ## Integration Tests