rusty-donkey/heave
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

review: add review comments to sqlite_build_statement function

Browse Source
This commit is contained in:
davidemazzocchi
2025-10-18 20:03:24 +02:00
parent cca78b2b56
commit 501ee9013a
1 changed files with 2 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
01.workspace/heave/src/fun/sqlite_build_statement.rs
View File

@@ -2,6 +2,7 @@ use crate::*;
const BASE_SELECT: &str = r#"SELECT * FROM entity WHERE 1=1"#; const BASE_SELECT: &str = r#"SELECT * FROM entity WHERE 1=1"#;
// REVIEW: instead of nested queries, switch to an inner join model
pub fn run(filter: &Filter) -> Result<String, FailedTo> { pub fn run(filter: &Filter) -> Result<String, FailedTo> {
let mut statement = String::from(BASE_SELECT); let mut statement = String::from(BASE_SELECT);
for (i, (name, _comparison, condition)) in filter.conditions().enumerate() { for (i, (name, _comparison, condition)) in filter.conditions().enumerate() {
@@ -23,6 +24,7 @@ pub fn run(filter: &Filter) -> Result<String, FailedTo> {
Ok(statement) Ok(statement)
} }
// REVIEW: evaluate to avoid these tests, do they make sense?
#[cfg(test)] #[cfg(test)]
mod tests { mod tests {
use super::*; use super::*;